Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using GCP KMS in example-gcp #153

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

AlCutter
Copy link
Collaborator

@AlCutter AlCutter commented Aug 20, 2024

This PR enables example-gcp to use GCP's KMS support for Ed25519 signatures.

Towards #7

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 78 lines in your changes missing coverage. Please review.

Project coverage is 35.17%. Comparing base (46ec9c2) to head (9c1ac8c).
Report is 69 commits behind head on main.

Files Patch % Lines
cmd/example-gcp/kms.go 0.00% 60 Missing ⚠️
cmd/example-gcp/main.go 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
- Coverage   35.80%   35.17%   -0.64%     
==========================================
  Files          16       33      +17     
  Lines        1363     2883    +1520     
==========================================
+ Hits          488     1014     +526     
- Misses        801     1759     +958     
- Partials       74      110      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mhutchinson mhutchinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you'll be updating the terraform to match. Docs (or ideally automated docs like terraform) for setting up this more complex example would be good.

@AlCutter
Copy link
Collaborator Author

Terraform for this has been added to #144, just trying to make sure it all works more or less as intended before I send that over to you.

@AlCutter AlCutter merged commit e7a8d34 into transparency-dev:main Aug 20, 2024
9 checks passed
@AlCutter AlCutter deleted the gcp_kms_signer branch August 20, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants