-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POSIX, GCP] Separate integration from publishing checkpoints #323
Merged
AlCutter
merged 18 commits into
transparency-dev:main
from
AlCutter:integrate_is_not_publish
Nov 21, 2024
Merged
[POSIX, GCP] Separate integration from publishing checkpoints #323
AlCutter
merged 18 commits into
transparency-dev:main
from
AlCutter:integrate_is_not_publish
Nov 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCutter
force-pushed
the
integrate_is_not_publish
branch
2 times, most recently
from
November 20, 2024 15:41
45b6062
to
0c0a4d4
Compare
AlCutter
force-pushed
the
integrate_is_not_publish
branch
3 times, most recently
from
November 20, 2024 16:33
a452096
to
5ac21be
Compare
AlCutter
force-pushed
the
integrate_is_not_publish
branch
from
November 20, 2024 16:38
5ac21be
to
f7ee996
Compare
mhutchinson
reviewed
Nov 21, 2024
AlCutter
force-pushed
the
integrate_is_not_publish
branch
6 times, most recently
from
November 21, 2024 15:51
eafe0a1
to
0bbfd0c
Compare
AlCutter
force-pushed
the
integrate_is_not_publish
branch
from
November 21, 2024 15:55
0bbfd0c
to
9120d73
Compare
AlCutter
force-pushed
the
integrate_is_not_publish
branch
from
November 21, 2024 16:57
621fd40
to
0f2abe6
Compare
AlCutter
force-pushed
the
integrate_is_not_publish
branch
from
November 21, 2024 16:59
0f2abe6
to
0124eac
Compare
mhutchinson
approved these changes
Nov 21, 2024
mhutchinson
approved these changes
Nov 21, 2024
AlCutter
changed the title
Separate integration from publishing checkpoints
[POSIX, GCP] Separate integration from publishing checkpoints
Nov 21, 2024
This was referenced Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disconnects the act of integrating new entries into a tree, from the act of publishing a new checkpoint which publicly commits to that new tree state for the POSIX and GCP storage implementations. (PRs for other implementations to follow.)
The rationale behind this change is two-fold:
Decoupling integration from publishing checkpoints helps free up implementations to be able to solve for both (1) and (2).
Helps with #309 and #198.