[GCP] Dedup storage experiment #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCutter
force-pushed
the
gcp_dedup_test
branch
from
05ff50b to
b6ecaf3
Compare
AlCutter
force-pushed
the
gcp_dedup_test
branch
4 times, most recently
from
8ba8b4d to
169ce5e
Compare
AlCutter
force-pushed
the
gcp_dedup_test
branch
3 times, most recently
from
3a9325b to
71cdbba
Compare
mhutchinson
approved these changes
Dec 5, 2024
AlCutter
force-pushed
the
gcp_dedup_test
branch
from
71cdbba to
5cccf8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an experimental GCP deduplication storage and allows the GCP conformance binary to optionally enable it.
It matches the
InMemoryDedupein its "decorator" approach.I needed to change the implementation of
InMemoryDedupeto not have it globally lock for every entry which came in - that doesn't compose well with lower layers which block.Towards #332