[MySQL] complete entry bundle implementation #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhutchinson
force-pushed
the
b364-entryBundleFixup
branch
from
ee2408d to
9e22f44
Compare
This was referenced Dec 9, 2024
roger2hk
approved these changes
Dec 9, 2024
mhutchinson
force-pushed
the
b364-entryBundleFixup
branch
3 times, most recently
from
c10c06e to
72ff29d
Compare
|
@roger2hk PTAL - I redid this to use the table to store the number of entries. The implementation you reviewed parsed the bundle, but this isn't safe because CT has a different bundle format. |
mhutchinson
force-pushed
the
b364-entryBundleFixup
branch
from
72ff29d to
a57ea04
Compare
AlCutter
approved these changes
Dec 9, 2024
roger2hk
approved these changes
Dec 9, 2024
Good catch! |
MySQL API now checks that the number of entries returned in a bundle is not smaller than the number requested. It does this by parsing the entry bundle. This could be optimized by storing the bundle size in the table. Now this is fixed, the conformance personality is updated to set cache headers on the entry bundles to allow aggressive caching. Also fixed the checkpoint implementation to never cache, and handle not found properly.
The previous approach wouldn't work with the CT bundle encoding.
Worth being clear about why we're saying this is not found even if _something_ is available.
While we're making breaking changes to the schema, might as well do them all.
mhutchinson
force-pushed
the
b364-entryBundleFixup
branch
from
a57ea04 to
173cee0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL API now checks that the number of entries returned in a bundle is not smaller than the number requested. It does this by parsing the entry bundle. This could be optimized by storing the bundle size in the table.
Now this is fixed, the conformance personality is updated to set cache headers on the entry bundles to allow aggressive caching. Also fixed the checkpoint implementation to never cache, and handle not found properly.
This fixes #364.