[WIP] Resumable job execution prototype #553
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorwwwwwwwwwwwwwwwwwwww
requested review from
meatballhat,
Lyoness and
bogdanap
bogdanap
changed the title
ghost
reviewed
Dec 6, 2018
There was a problem hiding this comment.
Found some fixes!
P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).
| @@ -77,6 +77,10 @@ func (r *Remoter) Close() error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (r *Remoter) Chmod(path string, mode os.FileMode) error { | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still early stages. Lots of TODOs still left. And log writing is not fully working yet.But we're able to upload the agent to the job VM and connect to it when the stars align!
Worked on this with @bogdanap at the Old Amsterdam office.
refs https://github.com/travis-ci/reliability/issues/196
This branch is meant to explore the possibility of having resumable job execution by having worker talk to https://github.com/travis-ci/worker-agent, which should handle job runs and logs streaming.
The first part of this work - having the agent run a job and successfully stream the logs even after disconnection - was successful.
Currently in progress is persisting job execution state on the worker side.