got a decent error

treeverse · Jan 2, 2025 · 33ca670 · 33ca670
1 parent cd5b80d
commit 33ca670
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/pkg/api/helpers/errors.go b/pkg/api/helpers/errors.go
@@ -19,8 +19,9 @@ var (
 	ErrUnsupportedProtocol = errors.New("unsupported protocol")
 
 	// ErrRequestFailed is an error returned for failing lakeFS server replies.
-	ErrRequestFailed = errors.New("request failed")
-	ErrConflict      = errors.New("conflict")
+	ErrRequestFailed   = errors.New("request failed")
+	ErrConflict        = errors.New("conflict")
+	ErrProtectedBranch = errors.New("writing to protected branch")
 )
 
 const minHTTPErrorStatusCode = 400

diff --git a/pkg/api/helpers/upload.go b/pkg/api/helpers/upload.go
@@ -386,6 +386,9 @@ func (u *presignUpload) uploadObject(ctx context.Context) (*apigen.ObjectStats,
 	if linkResp.JSON200 != nil {
 		return linkResp.JSON200, nil
 	}
+	if linkResp.JSON403 != nil {
+		return nil, fmt.Errorf("link object to backing store: %w (%s)", ErrProtectedBranch, linkResp.Status())
+	}
 	if linkResp.JSON409 != nil {
 		return nil, ErrConflict
 	}