Default squash-merge behaviour must be OFF #8483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielshaqed
added
bug
|
♻️ PR Preview 95a9ca9 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
E2E Test Results - DynamoDB Local - Local Block Adapter |
My original PR introduced an entirely wrong behaviour which is _also_ a breaking change. Fix this bad default.
arielshaqed
force-pushed
the
bug/squash-merge-should-not-be-default
branch
from
9ef4efe to
95a9ca9
Compare
E2E Test Results - Quickstart |
N-o-Z
reviewed
Jan 9, 2025
| @@ -3826,27 +3826,33 @@ func TestController_MergeSquashing(t *testing.T) { | |||
|
|
|||
| cases := []struct { | |||
| Name string | |||
| Squash bool | |||
| Squash *bool | |||
There was a problem hiding this comment.
I think adding a scenario where the parameter is not passed explicitly would have caught this.
Might want to add another flavor
There was a problem hiding this comment.
Great idea! That's exactly what "default" does here :-)
arielshaqed
commented
Jan 9, 2025
| @@ -3826,27 +3826,33 @@ func TestController_MergeSquashing(t *testing.T) { | |||
|
|
|||
| cases := []struct { | |||
| Name string | |||
| Squash bool | |||
| Squash *bool | |||
There was a problem hiding this comment.
Great idea! That's exactly what "default" does here :-)
|
I suspect the Python HL wrapper Esti test is failing because of #8484. (It didn't catch this bug when I made it, in #8482, exactly because it doesn't run the current version!) So force-pushing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My original PR introduced an entirely wrong behaviour which is also a breaking change. Fix this bad default.
Closes #8482.