Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Charts don't render in React 19 RC #1054

Open
ZipBrandon opened this issue May 20, 2024 · 7 comments
Open

[Bug]: Charts don't render in React 19 RC #1054

ZipBrandon opened this issue May 20, 2024 · 7 comments
Labels
Status: In Progress We are actively fixing/implementing this issue/feature

Comments

@ZipBrandon
Copy link

ZipBrandon commented May 20, 2024

Tremor Version

3.17.2

Link to minimal reproduction

https://github.com/ZipBrandon/tremor-barchart-troubleshooting

Steps to reproduce

  1. clone and npm install
  2. npm run dev to view charts are not rendering
  3. change to 18.3.1 and npm install
  4. npm run dev to view charts are visible

What is expected?

Charts would render

What is actually happening?

Charts don't render

What browsers are you seeing the problem on?

No response

Any additional comments?

No response

@ZipBrandon ZipBrandon changed the title [Bug]: Charts don't render in React 19 [Bug]: Charts don't render in React 19 RC May 20, 2024
@severinlandolt
Copy link
Member

Hi! Tremor currently requires React 18.2+. V19 is not supported.

c.f. charts: recharts/recharts#4558

@severinlandolt severinlandolt added the Status: Blocked A fix for this issue is blocked on another internal or external fix being in place label May 20, 2024
@eps1lon
Copy link

eps1lon commented May 30, 2024

Should no longer be blocked by recharts. React 19 support landed in [email protected]. There are some small bugs to fix but it doesn't block @tremor/react from starting to work on React 19.

@severinlandolt
Copy link
Member

Thanks for the heads-up. Did not expect a react core member to wander around in our issues 🤣 Thank you!

@severinlandolt severinlandolt added Status: In Progress We are actively fixing/implementing this issue/feature and removed Status: Blocked A fix for this issue is blocked on another internal or external fix being in place labels May 30, 2024
@ZipBrandon
Copy link
Author

@eps1lon has been the real MVP popping in everywhere for React 19 support as I have been playing whack-a-mole!

@soyricardodev
Copy link

Hi, I had this problem too, and the BarCharts still don't displaying, so i debugged and see an unexpected error with XAxis component and the height prop height={rotateLabelX?.xAxisHeight} this prop give me this Warning: Received NaN for the height attribute. If this is expected, cast the value to a string. so I just simpli make this height={rotateLabelX?.xAxisHeight ?? 0} and my problem was fixed. This change was in the BarChart.tsx file of tremor, so i'm going to make my first pr

@alexmondaini
Copy link

Hi, is it the case that https://tremor.so/docs/visualizations/bar-chart the BarChart component is still not rendering right with react 19 ? any news on this since recharts should be supporting react 19.

@severinlandolt
Copy link
Member

severinlandolt commented Nov 9, 2024

Bumping the depencency, will report back!

Update: Got recharts working, but to publish a working package version, need to update a few dependencies 🔨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: In Progress We are actively fixing/implementing this issue/feature
Projects
None yet
Development

No branches or pull requests

5 participants