Rename to hide_on_login_page to hide_on_login #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit tests need updates: |
|
Once fixed I'll merge with next major release which will include at least Keycloak 26 as the default. |
It seems that Keycloak 26 deprecated hideOnLoginPage - see https://www.keycloak.org/docs/latest/upgrading/index.html#improving-performance-for-selection-of-identity-providers Using the deprecated hideOnLoginPage yields: Keycloak_identity_provider[x on y]/hide_on_login_page: defined 'hide_on_login_page' as 'true' (corrective)
nblock
force-pushed
the
hide_on_login
branch
from
c5dc99c
to
4ff80a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that Keycloak 26 deprecated hideOnLoginPage - see https://www.keycloak.org/docs/latest/upgrading/index.html#improving-performance-for-selection-of-identity-providers
Using the deprecated hideOnLoginPage yields: