ci: always post UI report comment

trezor · Nov 11, 2024 · 1c7e8d5 · 1c7e8d5
1 parent b40ce85
commit 1c7e8d5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 22 deletions.
diff --git a/.github/workflows/core.yml b/.github/workflows/core.yml
@@ -286,8 +286,6 @@ jobs:
           status: ${{ job.status }}
         if: ${{ always() && env.ACTIONS_DO_UI_TEST == 'true' }}
         continue-on-error: true
-      - uses: ./.github/actions/ui-comment
-        if: ${{ failure() && env.ACTIONS_DO_UI_TEST == 'true' }}
       - uses: ./.github/actions/upload-coverage
 
   # Click tests - UI.
@@ -705,19 +703,11 @@ jobs:
 
   core_ui_comment:
     name: Post comment with UI diff URLs
+    if: github.event_name == 'pull_request'
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
-          ref: ${{ github.event.pull_request.head.sha }}
-      - run: |
-          git fetch origin main
-          git diff --quiet origin/main...HEAD -- tests/ui_tests/fixtures.json || echo "FIXTURES_CHANGED=$?" >> $GITHUB_OUTPUT
-        id: check-fixtures-changed
       - uses: ./.github/actions/ui-comment
-        # TODO: always run if comment already exists
-        if: ${{ steps.check-fixtures-changed.outputs.FIXTURES_CHANGED == '1' }}
 
   core_upload_emu:
     name: Upload emulator binaries

diff --git a/.github/workflows/legacy.yml b/.github/workflows/legacy.yml
@@ -134,8 +134,6 @@ jobs:
           status: ${{ job.status }}
         continue-on-error: true
         if: ${{ always() && matrix.coins == 'universal' }}
-      - uses: ./.github/actions/ui-comment
-        if: ${{ failure() && matrix.coins == 'universal' }}
 
   legacy_upgrade_test:
     name: Upgrade test
@@ -216,19 +214,11 @@ jobs:
 
   legacy_ui_comment:
     name: Post comment with UI diff URLs
+    if: github.event_name == 'pull_request'
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
-          ref: ${{ github.event.pull_request.head.sha }}
-      - run: |
-          git fetch origin main
-          git diff --quiet origin/main...HEAD -- tests/ui_tests/fixtures.json || echo "FIXTURES_CHANGED=$?" >> $GITHUB_OUTPUT
-        id: check-fixtures-changed
       - uses: ./.github/actions/ui-comment
-        # TODO: always run if comment already exists
-        if: ${{ steps.check-fixtures-changed.outputs.FIXTURES_CHANGED == '1' }}
 
   legacy_upload_emu:
     name: Upload emulator binaries