Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify asserts on translations #4359

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Simplify asserts on translations #4359

merged 4 commits into from
Nov 25, 2024

Commits on Nov 25, 2024

  1. feat(tests): simplify asserts on translated strings

    @matejcik
    matejcik committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    5df93f5 View commit details
    Browse the repository at this point in the history

  2. feat(tests): raise a warning for a translation not found in language 

    we need to propagate stacklevel so that the warning is emitted at the
usage line instead of deep in translations.py

i mean
we don't _need_ need to
it's just nicer
    @matejcik
    matejcik committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    a7c75cb View commit details
    Browse the repository at this point in the history

  3. refactor(tests): rework Model.TR "go to right key" logic 

    this changes UI tests because in edge cases the carousel goes the other
(shorter) way
    @matejcik
    matejcik committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    7f70306 View commit details
    Browse the repository at this point in the history

  4. chore(tests): fix deprecation warning

    @matejcik
    matejcik committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    8b4423e View commit details
    Browse the repository at this point in the history