Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodiscovery #615

Closed
wants to merge 25 commits into from
Closed

Conversation

jnichols-git
Copy link
Member

Addresses #609

Implementation of automatic service discovery as an interface, with current implementation supporting discovery of kubernetes resources in a cluster pointed to by the local kubeconfig. Draft PR while implementing new discovery methods and more thorough testing--want to have the current work publicly-facing to allow for easier testing and feedback.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3175866858

  • 103 of 159 (64.78%) changed or added relevant lines in 11 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.3%) to 94.083%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/autodiscovery/options/options.go 17 19 89.47%
pkg/autodiscovery/queries/options.go 21 23 91.3%
pkg/autodiscovery/templates/options.go 13 15 86.67%
pkg/backends/alb/options/options.go 1 3 33.33%
pkg/backends/options/options.go 1 3 33.33%
pkg/autodiscovery/autodiscovery.go 30 35 85.71%
pkg/util/copiers/copiers.go 0 6 0.0%
pkg/backends/alb/client.go 15 23 65.22%
pkg/routing/routing.go 4 16 25.0%
pkg/util/strings/strings.go 0 15 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/backends/alb/client.go 1 84.8%
pkg/cache/bbolt/bbolt.go 4 88.55%
Totals Coverage Status
Change from base Build 3175847764: -0.3%
Covered Lines: 16124
Relevant Lines: 17138

💛 - Coveralls

…nal cluster_ip for intkube

Signed-off-by: jakenichols2719 <[email protected]>
…g local changes (swap out ingress full query with queries.go version

Signed-off-by: jakenichols2719 <[email protected]>
Signed-off-by: jakenichols2719 <[email protected]>
…o finish kube functionality rework.

Signed-off-by: jakenichols2719 <[email protected]>
Signed-off-by: jakenichols2719 <[email protected]>
Signed-off-by: jakenichols2719 <[email protected]>
Signed-off-by: jakenichols2719 <[email protected]>
Signed-off-by: jakenichols2719 <[email protected]>
@jnichols-git
Copy link
Member Author

A combination of old, unmerged code and forgetting to sign off on a couple of commits has made this PR too unwieldy. I have fixed locally and will make a new PR that is more up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants