-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flux fixes #659
Merged
Merged
Flux fixes #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jakenichols2719 <[email protected]>
…re isn't one Signed-off-by: jakenichols2719 <[email protected]>
Signed-off-by: jakenichols2719 <[email protected]>
…ickster but not invalid flux Signed-off-by: jakenichols2719 <[email protected]>
Signed-off-by: jakenichols2719 <[email protected]>
Signed-off-by: jakenichols2719 <[email protected]>
Pull Request Test Coverage Report for Build 7073340712Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
Signed-off-by: jakenichols2719 <[email protected]>
Signed-off-by: jakenichols2719 <[email protected]>
Signed-off-by: jakenichols2719 <[email protected]>
Signed-off-by: jakenichols2719 <[email protected]>
Signed-off-by: jakenichols2719 <[email protected]>
…plate URL Signed-off-by: jakenichols2719 <[email protected]>
jranson
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing some errors that I left in the Flux implementation. Queries should now properly parse from the request body for POST requests (idiomatic for flux), and should use the OPC if there's no timestep, which is now parsed out of the first
window()
oraggregateWindow()
found in the query, since using different timesteps for data in the DeltaProxyCache is probably bad.Running some tests with InfluxDB 2.0 locally and will undraft once that's done and confirmed OK.