Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape paths before matching with lua patterns #70

Closed
willothy opened this issue Jan 3, 2024 · 2 comments · Fixed by #68
Closed

Escape paths before matching with lua patterns #70

willothy opened this issue Jan 3, 2024 · 2 comments · Fixed by #68
Assignees
Labels
bug Something isn't working

Comments

@willothy
Copy link
Collaborator

willothy commented Jan 3, 2024

As seen in #67, paths containing % and other symbols can cause issues with lua patterns - we should escape or validate paths before matching against them.

@willothy willothy added the bug Something isn't working label Jan 3, 2024
@willothy willothy self-assigned this Jan 3, 2024
@tris203
Copy link
Owner

tris203 commented Jan 3, 2024

Should we just go back to using vim.fn.stdpath("config") to get the path?

The only other directory we would need to consider is after

@willothy
Copy link
Collaborator Author

willothy commented Jan 3, 2024

Should we just go back to using vim.fn.stdpath("config") to get the path?

The only other directory we would need to consider is after

hmm that may be a good idea, but lets look into the issue more before we decide - not sure if that will be needed if we escape everything properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants