Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Windows Support #68

Merged
merged 33 commits into from
Mar 30, 2024
Merged

feat: Windows Support #68

merged 33 commits into from
Mar 30, 2024

Conversation

tris203
Copy link
Owner

@tris203 tris203 commented Jan 2, 2024

This removes the dependency on mini.test
Add windows support by changing the searched dirs to be vim.fn.stdpath("config")
And adds tests for all OS's to CI

Closes #70

@tris203 tris203 force-pushed the crossplatform_tests branch from 5f6836b to 815bbb4 Compare January 2, 2024 21:00
@tris203 tris203 changed the title ci:Cross platform tests feat: Windows Support Jan 6, 2024
@tris203 tris203 requested a review from willothy January 6, 2024 23:18
@tris203 tris203 linked an issue Jan 6, 2024 that may be closed by this pull request
@tris203 tris203 force-pushed the crossplatform_tests branch from 7b3970d to f9bf525 Compare January 6, 2024 23:48
Copy link
Collaborator

@willothy willothy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small things then lgtm

lua/hawtkeys/ts.lua Outdated Show resolved Hide resolved
tests/hawtkeys/ui_spec.lua Outdated Show resolved Hide resolved
tests/hawtkeys/ui_spec.lua Show resolved Hide resolved
tests/hawtkeys/ui_spec.lua Outdated Show resolved Hide resolved
tests/hawtkeys/ui_spec.lua Outdated Show resolved Hide resolved
tests/hawtkeys/ui_spec.lua Outdated Show resolved Hide resolved
tests/hawtkeys/ui_spec.lua Outdated Show resolved Hide resolved
@tris203 tris203 requested a review from willothy January 7, 2024 13:15
@tris203 tris203 requested review from willothy and removed request for willothy January 12, 2024 20:02
@tris203
Copy link
Owner Author

tris203 commented Mar 29, 2024

@willothy do you think this is ready to merge too?

@willothy
Copy link
Collaborator

@willothy do you think this is ready to merge too?

CI passing so yessir, lgtm!

@tris203 tris203 merged commit edbcb02 into main Mar 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Escape paths before matching with lua patterns
2 participants