Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: testing and configurable iterative mapping #26

Merged
merged 17 commits into from
Dec 20, 2023
Merged

feat: testing and configurable iterative mapping #26

merged 17 commits into from
Dec 20, 2023

Conversation

tris203
Copy link
Owner

@tris203 tris203 commented Dec 19, 2023 •
edited
Loading

this refactors the mapping to take a config for custom maps, work on #16

currently, it hits 5 of the example mapping functions

TODO: Hit the other mapping examples, if anyone has anymore please put them here or in the issue

Additionally, will need to keep the sensible defaults for the mapping definitions and offer a way to put them in through config and merge them with the defaults

willothy
willothy approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@willothy willothy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once the queries are updated to use format strings

@tris203
Copy link
Owner Author

tris203 commented Dec 20, 2023

TODO:

  • Ability to set in config and merge in
  • Sensible defaults
  • Handle which key mappings - parse and hand off to which-key in a pcall?
  • Handle lazy key maps (expression_list)

willothy
willothy requested changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@willothy willothy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should reuse the buildArgs function imo

lua/hawtkeys/ts.lua Outdated Show resolved Hide resolved
lua/hawtkeys/ts.lua Outdated Show resolved Hide resolved
lua/hawtkeys/ts.lua Outdated Show resolved Hide resolved
lua/hawtkeys/ts.lua Outdated Show resolved Hide resolved
lua/hawtkeys/ts.lua Outdated Show resolved Hide resolved
@tris203 tris203 force-pushed the experimentalTreeMapping branch from 244c309 to e836d61 Compare December 20, 2023 10:41
willothy
willothy reviewed Dec 20, 2023
View reviewed changes
lua/hawtkeys/ts.lua Outdated Show resolved Hide resolved
@tris203
Copy link
Owner Author

tris203 commented Dec 20, 2023

also adds frame work for testing needed for #17

@tris203 tris203 marked this pull request as ready for review December 20, 2023 23:26
@tris203 tris203 requested a review from willothy December 20, 2023 23:26
willothy
willothy reviewed Dec 20, 2023
View reviewed changes
lua/hawtkeys/init.lua Outdated Show resolved Hide resolved
willothy
willothy reviewed Dec 20, 2023
View reviewed changes
lua/hawtkeys/init.lua Outdated Show resolved Hide resolved
@tris203 tris203 requested a review from willothy December 20, 2023 23:32
willothy
willothy approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@willothy willothy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tris203 tris203 changed the title feat: experimental mapping feat: testing and configurable iterative mapping Dec 20, 2023
@tris203 tris203 merged commit dae77e1 into main Dec 20, 2023
4 checks passed
@tris203 tris203 deleted the experimentalTreeMapping branch December 20, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willothy willothy willothy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tris203 @willothy