Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: highlight search matches and search result score #31

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

willothy
Copy link
Collaborator

No description provided.

Copy link
Owner

@tris203 tris203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of niggles then LGTM

lua/hawtkeys/ui.lua Outdated Show resolved Hide resolved
lua/hawtkeys/ui.lua Show resolved Hide resolved
@willothy
Copy link
Collaborator Author

willothy commented Dec 21, 2023

You should try this out if you haven't to see if you like the way it looks, I'm not sure how it will be with colorschemes other than my own. We could also set our own highlight groups for it and allow configuration of that.

@tris203
Copy link
Owner

tris203 commented Dec 21, 2023

You should try this out if you haven't to see if you like the way it looks, I'm not sure how it will be with colorschemes other than my own. We could also set our own highlight groups for it and allow configuration of that.

yeah, its a bit wierd on my theme. Moremsg is blue.

I would like to move the colours to config, but we also need sensible defaults. What about using the colours for the notify messages?
EDIT: or the healthmessages, there is healtherror, healthsuccess and healthwarning

@tris203
Copy link
Owner

tris203 commented Dec 21, 2023

or the git colours

  git = {
    add = "#4197a4", -- high score
    change = "#506d9c", -- mid score
    delete = "#c47981", -- low score
    ignore = "#8990b3" --already mapped
  },

@willothy willothy force-pushed the ui-highlight-matches branch from b11abea to 4e58870 Compare December 21, 2023 08:45
@willothy
Copy link
Collaborator Author

willothy commented Dec 21, 2023

You should try this out if you haven't to see if you like the way it looks, I'm not sure how it will be with colorschemes other than my own. We could also set our own highlight groups for it and allow configuration of that.

yeah, its a bit wierd on my theme. Moremsg is blue.

I would like to move the colours to config, but we also need sensible defaults. What about using the colours for the notify messages? EDIT: or the healthmessages, there is healtherror, healthsuccess and healthwarning

I think health messages is the move. Those should usually be the same colors, but I've seen a lot of variation in git colors

Edit: are health messages default highlights? They're not defined for me even on default colorscheme.

@willothy willothy force-pushed the ui-highlight-matches branch from 4e58870 to 47e0164 Compare December 21, 2023 09:17
@tris203
Copy link
Owner

tris203 commented Dec 21, 2023

f fg a m 0 p

is a search that should bring back all score options

i will test this when i get home

@willothy willothy force-pushed the ui-highlight-matches branch from 47e0164 to 64f45d0 Compare December 21, 2023 11:13
@willothy willothy force-pushed the ui-highlight-matches branch from 64f45d0 to 25fb290 Compare December 21, 2023 11:23
@tris203 tris203 self-requested a review December 21, 2023 11:26
@tris203 tris203 merged commit d56ec52 into tris203:main Dec 21, 2023
4 checks passed
@tris203
Copy link
Owner

tris203 commented Dec 21, 2023

another great contribution, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants