Skip to content

Commit

Permalink
Add CONTRIBUTING.md guide.
Browse files Browse the repository at this point in the history
  • Loading branch information
josh-nz committed May 31, 2024
1 parent b40c353 commit 79de800
Show file tree
Hide file tree
Showing 2 changed files with 44 additions and 8 deletions.
40 changes: 40 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# Contributing

Contributions are welcome. What is expected from contributors is outlined below. If at any stage you require help, please just ask!

## Issues first

If there is something specific you want to work on, then please open an issue/discussion first to avoid duplication of efforts. Then:

1. Fork the Project
2. Create your Feature Branch (`git checkout -b feature/AmazingFeature`)
3. Make your changes
4. Review the steps below before committing your changes
5. Commit your Changes (`git commit -m 'Add some AmazingFeature'`)
6. Push to the Branch (`git push origin feature/AmazingFeature`)
7. Open a Pull Request

## Before committing changes

### Update documentation

Ensure that the `README.md` is updated where changed due to the new feature.

### Lua annotations

Any new or changed functions and module level locals should be annotated with Lua specs. These not only provide documentation but also assist the Language Server with completion and signature information. You can learn more about Lua annotations [here](https://luals.github.io/wiki/annotations/).

### Add tests

Tests should be added to cover any changes or new features. These can be found in the `spec` folder. To run the tests, [Make](https://www.gnu.org/software/make/) is required. Run `make test` from the repository root.

### Format code

This project uses [StyLua](https://github.com/JohnnyMorganz/StyLua) to ensure consistent code formatting.

The StyLua documentation details a number of ways this tool can be installed, including an executable you can just download. Then from the root of this repository run `stylua -g **/*.lua` (or `stylua -g **\*.lua` if on Windows).

Please run StyLua before committing your code. Do not commit the StyLua executable to this repository.

### Conventional commits for Commits and PR

12 changes: 4 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,14 +85,10 @@ This plugin supports stable and nightly. >0.9 at the time of writing.

Contributions are what makes the open-source community such an amazing place to learn, inspire, and create. Any contributions you make are **greatly appreciated**.

If you have a suggestion to improve the plugin, please fork the repo and create a pull request. You can also simply open an issue with the tag "enhancement".
Don't forget to give the project a star! Thanks again!
If you have a suggestion to improve the plugin, please open an issue first, fork the repo, and create a pull request. More details on how to contribute can be found in CONTRIBUTING.md.

You can also simply open an issue with the tag "enhancement".

If there is something specific you want to work on then, please open an issue/discussion first to avoid duplication of efforts
If you have found a bug please open an issue, or submit a PR with a failing test.

1. Fork the Project
2. Create your Feature Branch (`git checkout -b feature/AmazingFeature`)
3. Commit your Changes (`git commit -m 'Add some AmazingFeature'`)
4. Push to the Branch (`git push origin feature/AmazingFeature`)
5. Open a Pull Request
Don't forget to give the project a star! Thanks again!

0 comments on commit 79de800

Please sign in to comment.