Native Endianness for BYTES datatype serialization #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nv-kmcgill53
approved these changes
Jul 11, 2023
Tabrizian
approved these changes
Jul 12, 2023
nnshah1
commented
Jul 12, 2023
nnshah1
commented
Jul 12, 2023
nnshah1
commented
Jul 12, 2023
updating to be explicit in choice to use native format
updated to be explicit in choice to use native format
updated to be explicit in choice to use native byte order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support Big Endian architectures and align python backend handling of BYTES tensors with other backends, this change removes the explicit little endian flag to serialize and deserialize the length of a BYTES tensor element.
Note: this change alone is not sufficient for Big Endian support but is part of a set of changes also required in the server.