Setting max_gpu_fraction as in Tensorflow backend #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any update on this? |
|
I haven't heard from the owners of the repo yet. Is someone available for a code review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR permits setting the a max_gpu_fraction for the pytorch backend.
Pytorch allows setting the max gpu fraction through the
CUDACachingAllocator. The user of the pytorch_backend can set the memory fraction in the same fashion as in the tensorflow backend. The memory fraction applies to all models.I am a bit uncertain about how to handle the case with multiple GPUs and would appreciate feedback about desired behavior in this case.