-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function barrier to fix HG shock capturing on macOS ARM #1462
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the quick fix!
Note that when this is approved, the same should be done for the other indicators as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Good point. Once your approach chosen here gets the green light of @sloede, the other indicators should be adapted in the same way - but maybe in another PR |
Codecov Report
@@ Coverage Diff @@
## main #1462 +/- ##
==========================================
- Coverage 95.71% 92.95% -2.76%
==========================================
Files 358 358
Lines 29655 29639 -16
==========================================
- Hits 28382 27548 -834
- Misses 1273 2091 +818
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Closes #1457.
Other example files using
IndicatorHennemannGassner
were also broken on macOS ARM. These were fixed as well.E.g.,
p4est_2d_dgsem/elixir_euler_blast_wave_amr.jl
andtree_3d_dgsem/elixir_euler_shockcapturing_amr.jl
.