-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict StartUpDG.jl to 0.17.6 #1663
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1663 +/- ##
==========================================
+ Coverage 85.12% 92.96% +7.83%
==========================================
Files 418 419 +1
Lines 34229 34268 +39
==========================================
+ Hits 29137 31854 +2717
+ Misses 5092 2414 -2678
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Another problem is that older versions of Trixi.jl still allow the recent version of StartUpDG.jl. Could you maybe instead just make a PR with the required update for Trixi.jl and set the minimum version of StartUpDG.jl to v0.17.7? |
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
Sure, no problem - I'll add that today. This PR was just intended as a temporary fix in the meantime, so when I submit that new PR we would be able to close this one. |
Closing in favor of #1665 |
StartUpDG v0.17.7 fixes the type piracy issue #1639, but now there are duplicate definitions of
RefElemData
forSummationByPartsOperators.AbstractDerivativeOperator
.This will restrict the version to the previous one until a PR is made to remove the type piracy