Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging for breaking release v0.6.0 #1705

Merged
merged 7 commits into from
Nov 12, 2023
Merged

Staging for breaking release v0.6.0 #1705

merged 7 commits into from
Nov 12, 2023

Conversation

sloede
Copy link
Member

@sloede sloede commented Nov 4, 2023

The purpose of this PR and branch is to collect all breaking changes for v0.6 before merging them at once to main.

If possible, we should try to keep it's history clean such that we can do a linear merge to main, ensuring that we keep the individual contributions separate.

Already merged:

Closes #1310.

TODO

This comment was marked as off-topic.

@ranocha
Copy link
Member

ranocha commented Nov 7, 2023

Remember: Don't merge main into this branch, rebase locally and resolve conflicts there - let the git push --force be with you

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fbf7d54) 96.19% compared to head (5fd3d73) 96.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1705      +/-   ##
==========================================
+ Coverage   96.19%   96.23%   +0.03%     
==========================================
  Files         432      425       -7     
  Lines       34694    34253     -441     
==========================================
- Hits        33373    32960     -413     
+ Misses       1321     1293      -28     
Flag Coverage Δ
unittests 96.23% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...t_3d_dgsem/elixir_mhd_alfven_wave_nonconforming.jl 100.00% <ø> (ø)
...ples/structured_3d_dgsem/elixir_mhd_alfven_wave.jl 100.00% <ø> (ø)
...ples/tree_1d_dgsem/elixir_mhd_briowu_shock_tube.jl 100.00% <ø> (ø)
...es/tree_1d_dgsem/elixir_mhd_ryujones_shock_tube.jl 100.00% <ø> (ø)
...s/tree_1d_dgsem/elixir_mhd_shu_osher_shock_tube.jl 100.00% <ø> (ø)
...1d_dgsem/elixir_shallowwater_twolayer_dam_break.jl 100.00% <ø> (ø)
...gsem/elixir_shallowwater_twolayer_well_balanced.jl 100.00% <ø> (ø)
...gsem/elixir_shallowwater_twolayer_well_balanced.jl 100.00% <ø> (ø)
...2d_dgsem/elixir_shallowwater_twolayer_dam_break.jl 100.00% <ø> (ø)
...gsem/elixir_shallowwater_twolayer_well_balanced.jl 100.00% <ø> (ø)
... and 18 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sloede
Copy link
Member Author

sloede commented Nov 11, 2023

All tests seem to pass. All PRs have been merged. LGTM from my side.

@ranocha will you do the honors?

@sloede sloede marked this pull request as ready for review November 11, 2023 17:07
@sloede sloede requested a review from ranocha November 11, 2023 17:08
@ranocha
Copy link
Member

ranocha commented Nov 11, 2023

I'll do, thanks! I just want to have a final look at a few things and check CI on main to release a last v0.5 version before we go to v0.6.

sloede and others added 7 commits November 11, 2023 21:14
* Remove all neural network indicator stuff from `src/`

* Migrate neural network tests

* Migrate neural network examples

* Migrate test dependencies

* Update NEWS.md

* Fix typo

* Remove Requires.jl-based use of Flux.jl

* Fix formatting

* Add migration of indicators to section with breaking changes

---------

Co-authored-by: Hendrik Ranocha <[email protected]>
* Make parabolic terms non-experimental

* Make NSE a separate item

* Add MPI to supported features

* Mention that parabolic terms are now officially supported in NEWS.md

Co-authored-by: Hendrik Ranocha <[email protected]>
* remove previously deprecated functions

* fix typo in NEWS.md about deprecation vs removal

* fix literate tutorial

* removing other deprecation

* format

* Revert "fix typo in NEWS.md about deprecation vs removal"

This reverts commit 6b03020.
…1409)

* add gradient variable type parameter

* fix parabolic literate test

* remove trailing comment

* remove unnecessary abstract type

* move gradient variable structs

* formatting

* fix dropped changes

* try to fix doc tests

* fixing navier stokes 1D

* formatting

* remove duplicate GradientVariablesPrimitive/Entropy definition

* update news
…r equations (#1508)

* Add flux_nonconservative_ersing_etal

* Change formulation of flux_nonconservative_ersing

* remove old fluxes (fjordholm, wintermeyer)

* Update tests for new flux_ersing_etal

* Add flux_nonconservative_ersing for standard SWE

* Edit comments, change flux in elixir

* fix well-balanced test

* Update src/Trixi.jl

Change order of exporting statements

Co-authored-by: Andrew Winters <[email protected]>

* fix indentation

* fix indentation II

* Update src/equations/shallow_water_2d.jl

Co-authored-by: Andrew Winters <[email protected]>

* fix energy total function

* Apply formatter

* add docstring references

* remove flux_nonconservative_fjordholm_etal

* apply formatter

* Format examples

---------

Co-authored-by: Andrew Winters <[email protected]>
Co-authored-by: Hendrik Ranocha <[email protected]>
* Breaking changes HLL MHD

* format

* format examples

* hlle

* fix

* news, tests, example changes

* fmt

* remove left-right-biased flux from test

* Set version to v0.6.0

* Migrate neural network-based indicators to new repository (#1701)

* Remove all neural network indicator stuff from `src/`

* Migrate neural network tests

* Migrate neural network examples

* Migrate test dependencies

* Update NEWS.md

* Fix typo

* Remove Requires.jl-based use of Flux.jl

* Fix formatting

* Add migration of indicators to section with breaking changes

---------

Co-authored-by: Hendrik Ranocha <[email protected]>

* fix hlle noncartesian 2d

* remove parantheses

* correct test vals

* Make parabolic terms nonexperimental (#1714)

* Make parabolic terms non-experimental

* Make NSE a separate item

* Add MPI to supported features

* Mention that parabolic terms are now officially supported in NEWS.md

Co-authored-by: Hendrik Ranocha <[email protected]>

* Deprecate some `DGMultiMesh` constructors  (#1709)

* remove previously deprecated functions

* fix typo in NEWS.md about deprecation vs removal

* fix literate tutorial

* removing other deprecation

* format

* Revert "fix typo in NEWS.md about deprecation vs removal"

This reverts commit 6b03020.

* add gradient variable type parameter to `AbstractEquationsParabolic` (#1409)

* add gradient variable type parameter

* fix parabolic literate test

* remove trailing comment

* remove unnecessary abstract type

* move gradient variable structs

* formatting

* fix dropped changes

* try to fix doc tests

* fixing navier stokes 1D

* formatting

* remove duplicate GradientVariablesPrimitive/Entropy definition

* update news

* bring downloads back

* fix failing test

* fmt

---------

Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
Co-authored-by: Hendrik Ranocha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release v0.6
5 participants