-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove AMR CB from HLLE 2D Tree test #1720
Remove AMR CB from HLLE 2D Tree test #1720
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1720 +/- ##
==========================================
- Coverage 83.00% 77.39% -5.61%
==========================================
Files 431 431
Lines 34665 34624 -41
==========================================
- Hits 28772 26797 -1975
- Misses 5893 7827 +1934
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
We see slight deviations for the HLLE 2D Tree test
https://github.com/trixi-framework/Trixi.jl/actions/runs/6795610704/job/18474033572?pr=1708#step:7:5482
which I cannot reproduce on my local machine. Removing the AMR CB hopefully resolves this.