-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Trixi2Vtk.jl to downstream tests #1722
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Thanks! Looks good to me if tests pass later. We should also add the new downstream test to the required CI checks |
👍 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1722 +/- ##
==========================================
+ Coverage 74.61% 76.21% +1.60%
==========================================
Files 431 431
Lines 34600 34644 +44
==========================================
+ Hits 25815 26401 +586
+ Misses 8785 8243 -542
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Looks like the downstream tests pass and only execute the subset that is marked as an "upstream" test - LGTM from my side |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Requires trixi-framework/Trixi2Vtk.jl#79 to be merged first + a subsequent run of this PR to make sure that everything works as expected.