Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trixi2Vtk.jl to downstream tests #1722

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

sloede
Copy link
Member

@sloede sloede commented Nov 8, 2023

Requires trixi-framework/Trixi2Vtk.jl#79 to be merged first + a subsequent run of this PR to make sure that everything works as expected.

@sloede sloede requested a review from ranocha November 8, 2023 10:34
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@ranocha
Copy link
Member

ranocha commented Nov 8, 2023

Thanks! Looks good to me if tests pass later. We should also add the new downstream test to the required CI checks

@sloede
Copy link
Member Author

sloede commented Nov 8, 2023

We should also add the new downstream test to the required CI checks

👍

@sloede sloede closed this Nov 8, 2023
@sloede sloede reopened this Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (276dc3c) 74.61% compared to head (642a5dd) 76.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1722      +/-   ##
==========================================
+ Coverage   74.61%   76.21%   +1.60%     
==========================================
  Files         431      431              
  Lines       34600    34644      +44     
==========================================
+ Hits        25815    26401     +586     
+ Misses       8785     8243     -542     
Flag Coverage Δ
unittests 76.21% <ø> (+1.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 49 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sloede
Copy link
Member Author

sloede commented Nov 8, 2023

Looks like the downstream tests pass and only execute the subset that is marked as an "upstream" test - LGTM from my side

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ranocha ranocha merged commit 9acaa90 into main Nov 9, 2023
56 of 66 checks passed
@ranocha ranocha deleted the msl/add-downstream-test-for-trixi2vtk branch November 9, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants