-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make min_max_speed_davis
default wave speed estimate for FluxHLL()
#1743
Make min_max_speed_davis
default wave speed estimate for FluxHLL()
#1743
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
…g/Trixi.jl into HLL_WavespeedDefault_Davis
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1743 +/- ##
==========================================
- Coverage 96.38% 95.96% -0.42%
==========================================
Files 455 455
Lines 36391 36391
==========================================
- Hits 35074 34921 -153
- Misses 1317 1470 +153
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The changes in the test directory stem from those elixirs for which the speed estimates have been exchanged. |
examples/structured_2d_dgsem/elixir_euler_rayleigh_taylor_instability.jl
Outdated
Show resolved
Hide resolved
examples/structured_2d_dgsem/elixir_euler_rayleigh_taylor_instability.jl
Outdated
Show resolved
Hide resolved
…g/Trixi.jl into HLL_WavespeedDefault_Davis
examples/p4est_3d_dgsem/elixir_euler_source_terms_nonconforming_earth.jl
Show resolved
Hide resolved
Is it necessary to merge |
…g/Trixi.jl into HLL_WavespeedDefault_Davis
See #1721 and #1726
In this version, we keep
min_max_speed_naive
.Closes #1721