-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize p4est and t8code only if possible #1745
Initialize p4est and t8code only if possible #1745
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1745 +/- ##
==========================================
- Coverage 96.28% 96.27% -0.01%
==========================================
Files 428 428
Lines 34635 34639 +4
==========================================
+ Hits 33345 33347 +2
- Misses 1290 1292 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM once @ranocha is happy as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot 👍
With trixi-framework/P4est.jl#93 and DLR-AMR/T8code.jl#40 it is now possible to load P4est.jl and T8code.jl if MPIPreferences are set, but no preferences for P4est.jl or T8code.jl, respectively. For Trixi.jl this means that using MPI with a custom MPI implementation is more convenient, when p4est and/or t8code is not needed, e.g., if one wants to run a simulation that uses a
TreeMesh
since no preferences for P4est.jl and T8code.jl need to be set. This PR also prepares #1706, which can be merged after this PR.