-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test vals of failing tests for upstream packages #1760
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1760 +/- ##
===========================================
+ Coverage 67.81% 92.75% +24.94%
===========================================
Files 431 431
Lines 34785 34889 +104
===========================================
+ Hits 23587 32358 +8771
+ Misses 11198 2531 -8667
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still weird but the new tests seem to be fine 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Got finally all format errors |
See test failures in recent CI runs
https://github.com/trixi-framework/Trixi.jl/actions/runs/7017090127/job/19089672351?pr=1756#step:7:3702
https://github.com/trixi-framework/Trixi.jl/actions/runs/7017086643/job/19089662564?pr=1755#step:7:3702