-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Central SBP finite difference solver for UnstructuredMesh2D
#1773
Central SBP finite difference solver for UnstructuredMesh2D
#1773
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1773 +/- ##
==========================================
- Coverage 96.24% 92.44% -3.80%
==========================================
Files 431 433 +2
Lines 34896 35049 +153
==========================================
- Hits 33583 32400 -1183
- Misses 1313 2649 +1336
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Please find some comments below.
Co-authored-by: Hendrik Ranocha <[email protected]>
This implements a new volume integral and a few additional containers such that the
FDSBP
solver type works on curvilinearUnstructuredMesh2D
. Two elixirs are added for the compressible Euler equations to test converges and free-stream preservation. This extracts the central SBP solver that is working from #1295 (as suggested in #1295 (comment)). There are still issues and open questions about the Upwind FDSBP on unstructured domains.