-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix link to download notebook badge in documentation #1801
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Thanks for providing a fix! Instead of storing the badges here, you could also just use the shields.io links directly. If those cease to work, we are in trouble anyways. |
Note that if shields.io links are used anyway, the advantage of using them everywhere is that one can easily modify the link to change the shown text or color. |
🚜 |
Thanks for the suggestion. I changed it in e339958. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
The old link to the download badge doesn't work anymore. This PR replaces the link with a new self-generated one.
To prevent this from happening in the future for the link to the nbviewer badge, I updated it as well.
New badges are created directly with https://shields.io/:
https://img.shields.io/badge/render-nbviewer-f37726
https://img.shields.io/badge/raw-notebook-4cc61e