Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase minimum julia version to v1.10 #101

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

bennibolm
Copy link
Contributor

@bennibolm bennibolm commented Dec 20, 2024

PR 2214 increase the minimum required Julia version for Trixi.jl to v1.10. This PR updates it for Trixi2Vtk.jl.

test/test_trixi2vtk.jl Outdated Show resolved Hide resolved
@sloede
Copy link
Member

sloede commented Dec 20, 2024

For some reason, the p4est tests fail. Do they just need updated reference files or what's the deal here?

@bennibolm
Copy link
Contributor Author

For some reason, the p4est tests fail. Do they just need updated reference files or what's the deal here?

I was wondering about that as well.
First, I wasn't even sure, if it would work to just set the commit hash to the commit in my branch as I did in the last commit. Still not fully sure, if it should work 😅 So, I still have some hope that the errors disappear when the reference files are updated.
Secondly, @benegee also got similar result in the T8codeMesh-Trixi2Vtk PR. His Windows tests also work, but Ubuntu and macOS don't. There, we were very confused that some tests even work at all, since there are no T8codeMesh files in the reference file repository yet.
It seems to have something to do with the function get_reference_file and that it just uses some sort of local files when the file path doesn't exists(?). Please correct me if I got that wrong.

@sloede
Copy link
Member

sloede commented Dec 20, 2024

It seems to have something to do with the function get_reference_file and that it just uses some sort of local files when the file path doesn't exists(?).

By default it uses a file it finds locally, such that multiple tests using the same input file do not have to download it over and over again. A quick test if the old files somehow "pollute" the tests is by setting the default value of the force kwarg to true, such that each reference file must be downloaded anew each time it is used. If this fixes the issues, it would be a strong indicator that some caching is going wrong and we can fix it.

@bennibolm bennibolm changed the title WIP: Increase minimum julia version to v1.10 Increase minimum julia version to v1.10 Dec 23, 2024
@bennibolm bennibolm marked this pull request as ready for review December 23, 2024 10:20
@bennibolm bennibolm requested a review from sloede December 23, 2024 10:22
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sloede sloede merged commit c629928 into main Dec 23, 2024
8 of 9 checks passed
@sloede sloede deleted the bb/increase-minimum-julia-version-to-v1.10 branch December 23, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants