Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reference commit for old versions of Julia/Trixi.jl #91

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Apr 5, 2024

The current version of Trixi.jl requires Julia v1.8. Thus, we need to use the old reference commit for tests on Julia v1.7. Xref #90

@ranocha ranocha requested a review from patrickersing April 5, 2024 13:21
Copy link
Contributor

@patrickersing patrickersing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for figuring this out.

Copy link
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrewwinters5000 andrewwinters5000 merged commit 110975f into main Apr 8, 2024
11 checks passed
@andrewwinters5000 andrewwinters5000 deleted the ranocha-patch-1 branch April 8, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants