Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Covariant formulation of the shallow water equations #58

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

cleanup

43f9dc1
Select commit
Loading
Failed to load commit list.
Open

Covariant formulation of the shallow water equations #58

cleanup
43f9dc1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 8, 2025 in 0s

90.40% (+0.94%) compared to e7c1de7

View this Pull Request on Codecov

90.40% (+0.94%) compared to e7c1de7

Details

Codecov Report

Attention: Patch coverage is 95.45455% with 16 lines in your changes missing coverage. Please review.

Project coverage is 90.40%. Comparing base (e7c1de7) to head (43f9dc1).

Files with missing lines Patch % Lines
src/equations/covariant_advection.jl 72.22% 5 Missing ⚠️
src/equations/covariant_shallow_water.jl 95.68% 5 Missing ⚠️
src/equations/shallow_water_3d.jl 0.00% 4 Missing ⚠️
src/equations/equations.jl 97.36% 1 Missing ⚠️
...vers/dgsem_p4est/dg_2d_manifold_in_3d_covariant.jl 98.38% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   89.46%   90.40%   +0.94%     
==========================================
  Files          20       21       +1     
  Lines        1803     2106     +303     
==========================================
+ Hits         1613     1904     +291     
- Misses        190      202      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov