Using jquery to check if a funciton is passed as argument. This way i… #121
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s more thorough (see implementation) ie it also validates objects that are functions tla-1734
|
Are you sure you are targeting master with this patch? If so you need a rebase. |
|
Actually, we are using an older version of Troopjs (https://github.com/troopjs/troopjs/releases/tag/3.0.0-pr.2%2Bfa7fcdb) which actually does not seem to be using this as a dependency. We forked that version of Troopjs and made the change there -- maybe we should consider upgrading to the latest? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s more thorough (see implementation), it also validates objects that are functions tla-1734