-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update index.md.hbs #7
Open
rosekaron
wants to merge
7
commits into
troopjs:develop
Choose a base branch
from
rosekaron:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a934441
Update index.md.hbs
rosekaron 631ed1b
Update bundle.hbs
rosekaron 79e6fe3
Update bundle.hbs
rosekaron 6fb1094
Update bundle.hbs
rosekaron 4cdc83a
Update bundle.hbs
rosekaron 6c50d4a
Update bundle.hbs
rosekaron 5528f37
Update index.md.hbs
rosekaron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,31 +4,36 @@ section: development | |
title: Contribution Guideline | ||
--- | ||
|
||
> Feeling like part of this Troop? Here's how you can contribute. | ||
> Thank you for your interest in contributing to TroopJS. We value and welcome everyone's opinion so in order to encourage you, we'll try to make the guidelines simple and sweet. | ||
|
||
## Questions | ||
##Let us hear your pain. | ||
|
||
We love questions, and we love knowing how you're using TroopJS. Please create a new issue in TroopJS's | ||
revelant modules repositories, e.g. [troopjs-core](https://github.com/troopjs/troopjs-core) but not in | ||
the bundle [repository](https://github.com/troopjs/troopjs) unless it truely cannot fall into any of the existing modules. | ||
Most of the modules that's been added to the TroopJS framework are a result of feedback gathered from our early adopters. Help us make TroopJS work for you by [letting us hear your pain](https://github.com/troopjs/troopjs/issues/new). Remember to be nice and say please. | ||
|
||
## Reporting issues | ||
##Satisfied with TroopJS? | ||
|
||
Please read the following guidelines before opening any issue. | ||
Good. [It will be wonderful if you can tell us why](https://github.com/troopjs/troopjs/issues/new). | ||
|
||
##Questions/ Discussions? | ||
|
||
Please visit our discussion forum. | ||
|
||
1. **Search for existing issues.** To avoid duplicate issues, it would help us out if you could please check first to see if someone else has reported the same issue. Moreover, the issue may have already been resolved with a fix available. | ||
2. **Create an isolated and reproducible test case.** Be sure the problem exists in TroopJS's code with a [reduced test case](http://css-tricks.com/reduced-test-cases/) that should be included in each bug report. | ||
3. **Include clear examples.** Make use of jsFiddle or jsBin to share your isolated test cases. | ||
4. **Share as much information as possible.** Include version of Assemble, customized or vanilla build, etc. where appropriate. Also include steps to reproduce the bug. | ||
## Reporting an issue | ||
|
||
Please read the following guidelines before opening any issue. | ||
|
||
1. **Search for existing issues.** Creating duplicate issues not only wastes your time, it slows us down too because it adds unnecessary admin work. Before you create an issue, check if the issue you are about to report already exists or if it's been resolved with a fix available. | ||
2. **Create isolated and reproducible test cases.** To ensure that the problem exists in TroopJS's code by building a [reduced test case](http://css-tricks.com/reduced-test-cases/). | ||
3. **Include clear examples.** Make use of jsFiddle or jsBin when you share your isolated test cases. | ||
4. **Share as much information as possible.** Include version of Assemble, customized or vanilla build, etc. where appropriate. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Include version of TroopJS |
||
|
||
## Pull requests | ||
|
||
* Pull requests for each TroopJS module shall be rebased against the head of the `develop` branch | ||
* Please refer from the PR to an existing issue to be explainatory | ||
* Associated tests shall be included as part of the pull request changes. | ||
* Changes shall follow our existing coding style especially in indentation and qutations | ||
* Try not to pollute your pull request with unintended changes--keep them simple and small | ||
* Pull requests for each TroopJS module will be rebased against the head of the `develop` branch. | ||
* Reference an existing issue with your pull requests to be explanatory. | ||
* Associated tests will be included as part of the pull request changes. | ||
* Changes should follow our existing coding style especially indentation and quotations. | ||
* Try not to pollute your pull request with unintended changes--keep them simple and small. | ||
|
||
## Coding Style | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make use of jsFiddle, jsBin or gist when...