Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-130557 / 24.10 / Grab debug information for apps #207

Merged
merged 7 commits into from
Aug 12, 2024
Merged

NAS-130557 / 24.10 / Grab debug information for apps #207

merged 7 commits into from
Aug 12, 2024

Conversation

sonicaj
Copy link
Member

@sonicaj sonicaj commented Aug 12, 2024

No description provided.

@sonicaj sonicaj added the jira label Aug 12, 2024
@sonicaj sonicaj requested a review from a team August 12, 2024 10:20
@sonicaj sonicaj self-assigned this Aug 12, 2024
@bugclerk bugclerk changed the title Grab debug information for apps NAS-130557 / 24.10 / Grab debug information for apps Aug 12, 2024
@bugclerk
Copy link

Jira URL: https://ixsystems.atlassian.net/browse/NAS-130557

1 similar comment
@bugclerk
Copy link

Jira URL: https://ixsystems.atlassian.net/browse/NAS-130557

yocalebo
yocalebo approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@yocalebo yocalebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any private fields here that need to be removed?

@codecov Codecov
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.35%. Comparing base (f2fd343) to head (ba92a2a).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   92.33%   92.35%   +0.02%     
==========================================
  Files         101      102       +1     
  Lines        2230     2238       +8     
==========================================
+ Hits         2059     2067       +8     
  Misses        171      171

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonicaj sonicaj merged commit 0dee6b3 into master Aug 12, 2024
6 checks passed
@sonicaj sonicaj deleted the apps-debug branch August 12, 2024 10:29
@bugclerk
Copy link

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Aug 12, 2024
@sonicaj
Copy link
Member Author

sonicaj commented Aug 12, 2024

@yocalebo we should be good app.query does not include the config by default now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yocalebo yocalebo yocalebo approved these changes

Assignees

@sonicaj sonicaj

Labels
jira no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sonicaj @bugclerk @yocalebo