Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132548 / 25.04 / Add NVME plugin #248

Merged
merged 4 commits into from
Nov 17, 2024
Merged

NAS-132548 / 25.04 / Add NVME plugin #248

merged 4 commits into from
Nov 17, 2024

Conversation

yocalebo
Copy link
Contributor

We have a severe lack of nvme information being captured in the debug. This remedies that problem based on input from platform team. This also stops calling smartctl -a since the command barfs a line in the output stating it's "legacy" and we should use -x instead.

@yocalebo yocalebo requested a review from a team November 16, 2024 14:53
@bugclerk
Copy link

@bugclerk bugclerk changed the title Add NVME plugin NAS-132548 / 25.04 / Add NVME plugin Nov 16, 2024
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 24 lines in your changes missing coverage. Please review.

Project coverage is 90.32%. Comparing base (c2b318f) to head (5506a70).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
ixdiagnose/plugins/nvme.py 42.50% 23 Missing ⚠️
ixdiagnose/plugins/smart.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
- Coverage   91.12%   90.32%   -0.81%     
==========================================
  Files         104      105       +1     
  Lines        2356     2397      +41     
==========================================
+ Hits         2147     2165      +18     
- Misses        209      232      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yocalebo yocalebo merged commit 80422c7 into master Nov 17, 2024
9 checks passed
@yocalebo yocalebo deleted the NAS-132548 branch November 17, 2024 13:30
@bugclerk
Copy link

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants