Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-129207 / 24.10 / Utilize NUT dummy-ups to facilitate UPS event CI testing #14049

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

bmeagherix
Copy link
Contributor

@bmeagherix bmeagherix commented Jul 19, 2024

Add the ability to specify dummy-ups driver, and add some tests that utilize it.

(Also, first updated the existing tests to use WS client, but didn't otherwise modify them.)


Passing CI test is here.

@bmeagherix bmeagherix added the WIP label Jul 19, 2024
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title Nas 129207 NAS-129207 / 24.10 / Nas 129207 Jul 19, 2024
@bmeagherix bmeagherix changed the title NAS-129207 / 24.10 / Nas 129207 NAS-129207 / 24.10 / Utilize NUT dummy-ups to facilitate UPS event CI testing Jul 19, 2024
@bmeagherix bmeagherix removed the WIP label Jul 19, 2024
@bmeagherix bmeagherix requested a review from a team July 19, 2024 22:28
tests/api2/test_530_ups.py Outdated Show resolved Hide resolved
tests/api2/test_530_ups.py Show resolved Hide resolved
tests/api2/test_530_ups.py Outdated Show resolved Hide resolved
tests/api2/test_530_ups.py Outdated Show resolved Hide resolved
tests/api2/test_530_ups.py Show resolved Hide resolved
tests/api2/test_530_ups.py Outdated Show resolved Hide resolved
tests/api2/test_530_ups.py Outdated Show resolved Hide resolved
tests/api2/test_530_ups.py Outdated Show resolved Hide resolved
tests/api2/test_530_ups.py Outdated Show resolved Hide resolved
Copy link
Contributor

@yocalebo yocalebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thanks!

@bmeagherix bmeagherix merged commit 4482243 into master Jul 22, 2024
2 of 3 checks passed
@bmeagherix bmeagherix deleted the NAS-129207 branch July 22, 2024 15:56
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants