NAS-130198 / 24.10 / Remove check for whether localhost connection is root #14068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anodos325
force-pushed
the
remove-root-tcpip-handling
branch
from
2955960 to
44c42f9
Compare
bugclerk
changed the title
bmeagherix
approved these changes
Jul 23, 2024
yocalebo
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
I'm okay with this, but please wait for @themylogin to give it a once over before merge.
themylogin
requested changes
Jul 24, 2024
themylogin
requested changes
Jul 24, 2024
We don't use this functionality internally and it's a potential security liability if someone decides to set up their own internal proxy to middlewared socket that's running as root.
anodos325
force-pushed
the
remove-root-tcpip-handling
branch
from
e2cba56 to
0673f0d
Compare
themylogin
approved these changes
Jul 25, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't use this functionality internally and it's a potential security liability if someone decides to set up their own internal proxy to middlewared socket that's running as root, or if an application allows root account and has access to host networking.