Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130214 / 24.10 / Make Job.wait_sync signature match Job.wait #14074

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

themylogin
Copy link
Contributor

@themylogin themylogin commented Jul 24, 2024

Parameters order was changed, but no callers use positional args so we're good.

@themylogin themylogin requested a review from a team July 24, 2024 11:50
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title Make Job.wait_sync signature match Job.wait NAS-130214 / 24.10 / Make Job.wait_sync signature match Job.wait Jul 24, 2024
@themylogin
Copy link
Contributor Author

time 0:10

@bugclerk
Copy link
Contributor

@themylogin themylogin merged commit 6b49a32 into master Jul 24, 2024
2 of 3 checks passed
@themylogin themylogin deleted the wait_sync branch July 24, 2024 11:51
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants