Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-130242 / 24.10 / improve test_002 #14079

Merged
merged 1 commit into from
Jul 25, 2024
Merged

NAS-130242 / 24.10 / improve test_002 #14079

merged 1 commit into from
Jul 25, 2024

Conversation

yocalebo
Copy link
Contributor

Improve this test by:

  1. using the test.integration.utils::call function
  2. use pytest.mark.skipif decorator

Passing test is here

@yocalebo yocalebo added the jira label Jul 25, 2024
@yocalebo yocalebo requested a review from a team July 25, 2024 12:14
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-130242

@bugclerk bugclerk changed the title improve test_002 NAS-130242 / 24.10 / improve test_002 Jul 25, 2024
@truenas truenas deleted a comment from bugclerk Jul 25, 2024
@yocalebo yocalebo merged commit 582182f into master Jul 25, 2024
2 of 3 checks passed
@yocalebo yocalebo deleted the improv-test002 branch July 25, 2024 13:01
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aiden3c aiden3c aiden3c approved these changes

Assignees
No one assigned
Labels
jira no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yocalebo @bugclerk @aiden3c