NAS-130230 / 24.10 / Prevent removing failover group from critical interfaces

[aiden3c]

This prevents clearing failover_group from a NIC marked as failover_critical

[bugclerk]

Jira URL: https://ixsystems.atlassian.net/browse/NAS-130230

[aiden3c]

Passing test (look for test_004_remove_critical_failover_group)

[yocalebo]

This changes the behavior of how an error is returned. Before this change, on interface create, we raised a CallError with specific verbiage. Now this will return a ValidationError with different error message on create.

On line 1046, we validate these during a create operation. We should probably add an else branch to that check (so we know it's an update operation) and raise your validation error.

[bugclerk]

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.