NAS-130256 / 24.10 / Avoid deadlocking during DS health initialization #14087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some edge cases with restarting middleware in which we can deadlock on the etc.generate lock for the kerberos group if we're joined to AD (by calling into directoryservices.health.check repeatedly). This fixes the issue by initializing the health state if required when we first enter the directoryservices.health.check method.
bugclerk
changed the title
bmeagherix
approved these changes
Jul 25, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some edge cases with restarting middleware in which we can deadlock on the etc.generate lock for the kerberos group if we're joined to AD (by calling into directoryservices.health.check repeatedly). This fixes the issue by initializing the health state if required when we first enter the directoryservices.health.check method.