Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132878 / 25.04 / add kfd device flag existence #15116

Merged
merged 3 commits into from
Dec 4, 2024
Merged

NAS-132878 / 25.04 / add kfd device flag existence #15116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9725745
add kfd device flag existence
stavros-k Dec 4, 2024
460ac17
update tests
stavros-k Dec 4, 2024
e0409f6
typo
stavros-k Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/middlewared/middlewared/plugins/apps/schema_normalization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ async def normalize_gpu_configuration(self, attr, value, complete_config, contex
}
if not any(gpu['vendor'] != 'NVIDIA' for gpu in gpu_choices.values()):
value['use_all_gpus'] = False
value['kfd_device_exists'] = os.path.exists('/dev/kfd')

for nvidia_gpu_pci_slot in list(value['nvidia_gpu_selection']):
if nvidia_gpu_pci_slot not in gpu_choices or gpu_choices[nvidia_gpu_pci_slot]['vendor'] != 'NVIDIA':
Expand Down
6 changes: 6 additions & 0 deletions src/middlewared/middlewared/pytest/unit/plugins/apps/test_normalize_gpu_options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,15 @@
],
{
'use_all_gpus': True,
'kfd_device_exists': False,
'nvidia_gpu_selection': {
'0000:01:00.0': 'NVIDIA GPU 1',
'0000:02:00.0': 'NVIDIA GPU 2'
}
},
{
'use_all_gpus': False,
'kfd_device_exists': False,
'nvidia_gpu_selection': {}
}

Expand All @@ -63,10 +65,12 @@
],
{
'use_all_gpus': True,
'kfd_device_exists': False,
'nvidia_gpu_selection': {}
},
{
'use_all_gpus': True,
'kfd_device_exists': False,
'nvidia_gpu_selection': {}
}

Expand Down Expand Up @@ -110,10 +114,12 @@
],
{
'use_all_gpus': True,
'kfd_device_exists': False,
'nvidia_gpu_selection': {}
},
{
'use_all_gpus': True,
'kfd_device_exists': False,
'nvidia_gpu_selection': {}
}

Expand Down
Loading