NAS-132813 / 25.04 / Convert pool.snapshottask to new API
#15164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
pool.snapshottask to new APIpool.snapshottask to new API
themylogin
reviewed
Dec 9, 2024
themylogin
reviewed
Dec 9, 2024
themylogin
reviewed
Dec 9, 2024
There was a problem hiding this comment.
Also I don't understand why do you want to use that validator module (it'll be eventually removed) and change it so massively. Let's just re-implement that field type like we did with LocalUsername, LocalGID. Also, let's put it into base types since other classes will also use it.
|
I was under the impression that we wanted to bring our old validators into the new API so I'll correct this. |
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
AfterValidator, the passed callable's return value is assigned to the field. For this reason, our validators should return the value that is passed to them or some modified version of the value. This change should not cause any issues since we have not been using the validators' return values until now.Tests: http://jenkins.eng.ixsystems.net:8080/job/tests/job/api_tests/2157/