NAS-133058 / 25.04 / simplify service.terminate_process #15194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yocalebo
force-pushed
the
fix-svc-term
branch
from
7171d96 to
2f7cea2
Compare
bugclerk
changed the title
themylogin
reviewed
Dec 12, 2024
bmeagherix
reviewed
Dec 12, 2024
| Returns: | ||
| boolean: True if process was terminated with SIGTERM, false if SIGKILL was used | ||
| """ | ||
| if pid == 0 or pid == os.getpid(): |
There was a problem hiding this comment.
Looking at kill(2) man page I wonder whether we should also eliminate all negative values of pid.
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
psutil is expensive in about every way imaginable. This method doesn't require using it so I've simplified the method to use built-in modules provided by python.
terminate_processsince it allowed terminating pid 0 or middlewared (itself)