Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132959 / 24.10.2 / Mark extent read-only if underlying zvol is R/O (by bmeagherix) #15196

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

bugclerk
Copy link
Contributor

Automatic cherry-pick failed. Please resolve conflicts by running:

git cherry-pick -x b4b7f7501ca3d512c2af120cd2cd4fef723f8853
git cherry-pick -x 6a93be9263c4bd9b0cc65ab5867892eaded0843b
git cherry-pick -x 0e803cfe2e4bc84a37a3a8a79c066e865a39d361

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~4
git cherry-pick -x bca13acb365ef5e95de7a111af2f78fb061ee4d1

If a SCST extent is based upon a zvol, then keep the extent ro setting in sync with the zvol readonly property.

  • Update extent ro prop if zvol readonly changes.
  • Update zvol readonly prop if extent is ro changed
  • Add unit test test__target_readonly_extent

  • CI test run is here.
  • Also did some manual testing with Windows client.

Original PR: #15195
Jira URL: https://ixsystems.atlassian.net/browse/NAS-132959

…15195)

* Update extent ro prop if zvol readonly changes.

* Update zvol readonly prop if extent is ro changed

* Add unit test test_36_target_readonly_extent

---------

Co-authored-by: Caleb <[email protected]>
(cherry picked from commit bca13ac)
@bmeagherix bmeagherix marked this pull request as ready for review December 12, 2024 19:58
@yocalebo yocalebo merged commit 693e4be into stable/electriceel Dec 13, 2024
1 check passed
@yocalebo yocalebo deleted the NAS-132959-24.10.2 branch December 13, 2024 11:57
@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants