NAS-133069 / 25.04 / Call get_memory_info() everywhere #15200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
bmeagherix
approved these changes
Dec 13, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to recent changes, there is no reason to use
psutilto return basic memory information. Especially since we're only using 2 lines from/proc/meminfooutput. Instead add aget_memory_info()helper function and call it everywhere.I also converted this from a
dataclassto aTypedDictbecause thedata classes.asdictfunction is notoriously slow (makes deepcopy's) and so while we saved memory by using a frozen dataclass we lost all efficiency by callingasdictin the truenas_meminfo netdata chart.