NAS-133075 / 25.04 / Move web shell logic to its own module #15205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
mgrimesix
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Flake8 complaints:
main.py line 610
def _load_api_versions(self) -> [APIVersion]:
should be
def _load_api_versions(self) -> list[APIVersion]:
webshell.py
lines 293, 321 and 331 have the following complaint:
line break before binary operator
Approving anyway as these are in current code.
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is merely a refactor of the web shell related logic and moving it to its own module to clear up
main.py. There should be no change in behavior.