Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132728 / 25.04 / Add cloud_backup.abort test #15210

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

creatorcary
Copy link
Contributor

This is the only cloud_backup endpoint not covered by our api tests yet.

@creatorcary creatorcary requested a review from a team December 13, 2024 22:01
@bugclerk bugclerk changed the title Add cloud_backup.abort test NAS-132728 / 25.04 / Add cloud_backup.abort test Dec 13, 2024
@bugclerk
Copy link
Contributor

# Ensure backup works after an abort
ssh(f"touch /mnt/{cloud_backup_task.local_dataset}/testfile")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we validate that testfile was successfully backed up?

Copy link
Contributor

@mgrimesix mgrimesix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants